feat: add srat box #527
Merged
feat: add srat box #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks. LGTM except the warning of the automated checks. Then we can merge. |
Contributor
Author
|
It's not clear to me what it's complaining about. I see But it makes no sense. |
Member
|
It seems to be the "extra" space before the colon which should be removed. I can't see anything else and I agree this is not super clear. |
The SamplingRateBox() is used to indicate an audio sampling rate greater than the value that can be represented in the AudioSampleEntry's samplerate field. See ISO/IEC 14496-12:2022 Section 12.2.3.1 Signed-off-by: James Almer <jamrial@gmail.com>
Contributor
Author
Ah, that could be it. Amended then. |
Member
|
Thanks ! |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SamplingRateBoxis used to indicate an audio sampling rate greater than the value that can be represented in the AudioSampleEntry's samplerate field.See ISO/IEC 14496-12:2022 Section 12.2.3.1