Skip to content

Conversation

@jamrial
Copy link
Contributor

@jamrial jamrial commented Nov 22, 2025

The SamplingRateBox is used to indicate an audio sampling rate greater than the value that can be represented in the AudioSampleEntry's samplerate field.

See ISO/IEC 14496-12:2022 Section 12.2.3.1

@rbouqueau
Copy link
Member

Thanks. LGTM except the warning of the automated checks. Then we can merge.

@jamrial
Copy link
Contributor Author

jamrial commented Nov 22, 2025

It's not clear to me what it's complaining about. I see

/home/runner/work/mp4box.js/mp4box.js/src/boxes/srat.ts
  8:16  error  Delete `·`  prettier/prettier

But it makes no sense.

@rbouqueau
Copy link
Member

It seems to be the "extra" space before the colon which should be removed. I can't see anything else and I agree this is not super clear.

The SamplingRateBox() is used to indicate an audio sampling rate greater than
the value that can be represented in the AudioSampleEntry's samplerate field.

See ISO/IEC 14496-12:2022 Section 12.2.3.1

Signed-off-by: James Almer <jamrial@gmail.com>
@jamrial
Copy link
Contributor Author

jamrial commented Nov 22, 2025

It seems to be the "extra" space before the colon which should be removed. I can't see anything else and I agree this is not super clear.

Ah, that could be it. Amended then.

@DenizUgur DenizUgur added this pull request to the merge queue Nov 22, 2025
Merged via the queue into gpac:main with commit 6cd6fda Nov 22, 2025
2 checks passed
@jamrial jamrial deleted the srat branch November 22, 2025 18:13
@rbouqueau
Copy link
Member

Thanks !

@github-actions
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants