Open
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently,
nullvalues are explicitly ignored and cause an error when parsing. This is not correct, because the GraphQL spec supports them. (ref).There are also quite a few open issues which refer to this problem, namely:
This PR provides support for
nullvalues. I tried to keep the implementation maximally "compliant" with the current codebase, but I am willing to make changes, just to merge this functionality.I assume that this project is already being used in quite a few production cases and such deviations from the spec are not acceptable. I see that there already are some PRs that introduce this change, which are outdated, I will try to keep mine up-to-date, just to get this merged.