-
Notifications
You must be signed in to change notification settings - Fork 122
feat(traces): add bulk trace seeding script with configurable options #7319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
30cb306 to
a33cbc4
Compare
Summary of ChangesHello @adambenhassen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a powerful new tool for developers and testers to generate and inject large-scale OpenTelemetry trace data into ClickHouse, facilitating robust testing and performance analysis of tracing functionalities. Concurrently, it implements a global feature flag to easily enable or disable OTEL tracing across the entire application environment, streamlining development workflows and feature rollout. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📚 Storybook DeploymentThe latest changes are available as preview in: https://pr-7319.hive-storybook.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a powerful trace seeding script and wires up the necessary feature flags to enable OTEL tracing. The script is well-designed, using server-side duplication in ClickHouse for efficiency. I've found a critical issue in the script that would prevent traces from being correctly associated with their target, and a couple of medium-severity issues related to argument parsing and random ID generation. The rest of the changes for enabling the feature flag look solid.
a33cbc4 to
d704b2e
Compare
d704b2e to
543009c
Compare
💻 Website PreviewThe latest changes are available as preview in: https://pr-7319.hive-landing-page.pages.dev |
|
🐋 This PR was built and pushed to the following Docker images: Targets: Platforms: Image Tag: |
543009c to
4404729
Compare
n1ru4l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 😻
Description:
Add a script for seeding massive trace datasets into ClickHouse with configurable parameters and chunked processing to avoid memory pressure issues.
Features:
Performance:
Usage:
Examples:
Execution Example: