v6: Add theme / density / font-size controls to settings dialog#4338
Draft
trevor-scheer wants to merge 2 commits into
Draft
v6: Add theme / density / font-size controls to settings dialog#4338trevor-scheer wants to merge 2 commits into
trevor-scheer wants to merge 2 commits into
Conversation
Fills in concrete preset values for `[data-density]` and `[data-font-size]` token blocks in `tokens.css`. Adds a new `SettingsDialog` component to `@graphiql/react` with `SegmentedControl`s for each axis, wired to `useGraphiQLSettings`. Settings persist via `localStorage`. The Monaco editor's font size follows the active preset. Wires `SettingsDialog` into the `graphiql` package's `ActivityBar`, replacing the inline settings UI there. Removes `forcedTheme` and `showPersistHeadersSettings` from `GraphiQLInterfaceProps`; both were deprecated props with no effect.
🦋 Changeset detectedLatest commit: a7baf11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kylin791-sys
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The settings dialog now exposes segmented controls for theme, density, and font size, backed by the
useGraphiQLSettingshook that landed in #4322. Concrete CSS variable values fill in the[data-density]and[data-font-size]token blocks intokens.css, so toggling a preset instantly reshapes spacing and typography across the whole UI. The Monaco editor's font size is kept in sync with the active preset viaeditor.updateOptions. TheSettingsDialogcomponent lives in@graphiql/reactand is wired into thegraphiqlpackage's activity bar, replacing the previous inline settings UI there.Test plan
data-themeattribute updates.--font-size-bodyand Monaco editor font size update.localStorage.