Skip to content

fix(audits): avoid false positives in 9ABE #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enisdenjo merged 3 commits into from
Jun 23, 2025
Merged

fix(audits): avoid false positives in 9ABE #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a78dbdf
fix(audits): avoid false positives in 9ABE
DoctorJohn Jun 6, 2025
0e477fe
fix(audits): update 9ABE to SHOULD to match spec
DoctorJohn Jun 6, 2025
b766aef
chore: update snapshot
DoctorJohn Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/audits/server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,11 @@ export function serverAudits(opts: ServerAuditOptions): Audit[] {
// Request POST
audit(
'9ABE',
'MAY respond with 4xx status code if content-type is not supplied on POST requests',
'SHOULD respond with 4xx status code if content-type is not supplied on POST requests',
async () => {
const res = await fetchFn(await getUrl(opts.url), {
method: 'POST',
body: JSON.stringify({ query: '{ __typename }' }),
});
ressert(res).status.toBeBetween(400, 499);
},
Expand Down
2 changes: 1 addition & 1 deletion tests/__snapshots__/audits.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ exports[`should not change globally unique audit ids 1`] = `
},
{
"id": "9ABE",
"name": "MAY respond with 4xx status code if content-type is not supplied on POST requests",
"name": "SHOULD respond with 4xx status code if content-type is not supplied on POST requests",
},
{
"id": "03D4",
Expand Down
Loading