predicates: replace instanceof with symbol based brand check #4468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
saihaj
approved these changes
Aug 6, 2025
yaacovCR
force-pushed
the
use-brand
branch
4 times, most recently
from
5c673b9 to
cfb5e91
Compare
JoviDeCroock
reviewed
Aug 8, 2025
JoviDeCroock
approved these changes
Aug 8, 2025
yaacovCR
changed the title
yaacovCR
changed the title
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
…#4468) This PR updates our predicates to rely on a brand check rather than `instanceof`. We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
…#4468) This PR updates our predicates to rely on a brand check rather than `instanceof`. We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 17, 2025
…#4468) This PR updates our predicates to rely on a brand check rather than `instanceof`. We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 18, 2025
…#4468) This PR updates our predicates to rely on a brand check rather than `instanceof`. We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
yaacovCR
added a commit
to yaacovCR/graphql-js
that referenced
this pull request
Dec 19, 2025
…#4468) This PR updates our predicates to rely on a brand check rather than `instanceof`. We still pass brand check to our `instanceOf` utility and in development mode use the same logic as previously to throw our error with multiple instances of `graphql`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our predicates to rely on a brand check rather than
instanceof.We still pass brand check to our
instanceOfutility and in development mode use the same logic as previously to throw our error with multiple instances ofgraphql.