Conversation
Contributor
|
Preview is ready. |
NikitaCG
reviewed
Oct 27, 2023
| export const transformPost = ( | ||
| postData: PostData, | ||
| lang: Lang, | ||
| {plugins}: TransformPostOptions = {}, |
Collaborator
There was a problem hiding this comment.
I think we need use agrument-object when arguments quantity more than 2, but it is breaking change. I suggest after merge of this PR to make edits in #137. can you create issue after merge this PR ?
NikitaCG
reviewed
Oct 30, 2023
package.json
Outdated
| { | ||
| "name": "@gravity-ui/blog-constructor", | ||
| "version": "5.7.2", | ||
| "version": "5.8.0-alpha.0", |
Contributor
Author
There was a problem hiding this comment.
nope, used for testing
e20ca7a to
8d14f92
Compare
NikitaCG
approved these changes
Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.