feat: used new component from gravity for number input#339
Merged
AshotHarutyunyan merged 4 commits intomainfrom Dec 11, 2025
Merged
feat: used new component from gravity for number input#339AshotHarutyunyan merged 4 commits intomainfrom
AshotHarutyunyan merged 4 commits intomainfrom
Conversation
AshotHarutyunyan
requested review from
NasgulNexus and
bocembocem
as code owners
Contributor
|
Preview is ready. |
Contributor
|
Playwright Test Component is ready. |
NasgulNexus
reviewed
Dec 11, 2025
| NumberSpec<undefined, InputComponentProps, LayoutComponentProps> | ||
| >; | ||
|
|
||
| export type NumberInput<InputComponentProps extends Record<string, any> | undefined = undefined> = |
Contributor
There was a problem hiding this comment.
Let's put things back the way they were
Contributor
Author
There was a problem hiding this comment.
there was conflicted exports with same naming I've checked this type is not used if there is need I can rename the component and revert this one
| > {} | ||
|
|
||
| export const NumberInput = < | ||
| T extends NumberInputProps<NumberProps> | StringInputProps<NumberProps>, |
Contributor
There was a problem hiding this comment.
Why are there StringInputProps here?
Now this is a separate component with a numeric input, let's leave it only NumberInputProps
and remove the text from the input NumberInputProps
Contributor
Author
There was a problem hiding this comment.
I've thought about that, but used this for backward capability, is that ok for us to support new type for this input?
NasgulNexus
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.