Skip to content

feat: add analytics events for title#1387

Merged
aeksandla merged 16 commits intomainfrom
aeksandla/analytics-for-title
Mar 13, 2026
Merged

feat: add analytics events for title#1387
aeksandla merged 16 commits intomainfrom
aeksandla/analytics-for-title

Conversation

@aeksandla
Copy link
Collaborator

@aeksandla aeksandla commented Mar 11, 2026

No description provided.

@gravity-ui-bot
Copy link
Contributor

gravity-ui-bot commented Mar 11, 2026

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

gravity-ui-bot commented Mar 11, 2026

Playwright Test Component is ready.

@aeksandla aeksandla marked this pull request as ready for review March 11, 2026 09:55
@aeksandla aeksandla requested a review from NikitaCG as a code owner March 11, 2026 09:55
@NikitaCG
Copy link
Collaborator

NikitaCG commented Mar 12, 2026

in this component analyticsEvent prop not forwarded https://github.com/gravity-ui/page-constructor/blob/main/src/blocks/Slider/Slider.tsx#L109
and in another components https://github.com/search?q=repo%3Agravity-ui%2Fpage-constructor%20%3CTitle&type=code

NikitaCG
NikitaCG requested changes Mar 12, 2026
View reviewed changes
src/components/Title/TitleItem.tsx Outdated
</span>
);

const handleClick = () => {
Copy link
Collaborator

@NikitaCG NikitaCG Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we need wrapped it in useCallback ?

@aeksandla
Copy link
Collaborator Author

aeksandla commented Mar 12, 2026

in this component analyticsEvent prop not forwarded https://github.com/gravity-ui/page-constructor/blob/main/src/blocks/Slider/Slider.tsx#L109 and in another components https://github.com/search?q=repo%3Agravity-ui%2Fpage-constructor%20%3CTitle&type=code

analyticsEvent is located inside the title prop
https://github.com/gravity-ui/page-constructor/blob/main/src/blocks/Slider/Slider.tsx#L110

because only TitleItem can be link

@aeksandla aeksandla merged commit ca10a21 into main Mar 13, 2026
4 checks passed
@aeksandla aeksandla deleted the aeksandla/analytics-for-title branch March 13, 2026 08:37
@gravity-ui-bot gravity-ui-bot mentioned this pull request Mar 13, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NikitaCG NikitaCG NikitaCG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aeksandla @gravity-ui-bot @NikitaCG