fix: reset canvas transform before clearing to prevent rendering artifacts#140
Open
Antamansid wants to merge 1 commit intogravity-ui:mainfrom
Open
fix: reset canvas transform before clearing to prevent rendering artifacts#140Antamansid wants to merge 1 commit intogravity-ui:mainfrom
Antamansid wants to merge 1 commit intogravity-ui:mainfrom
Conversation
Contributor
|
Preview is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CanvasApi.clear()usedclearRectwithout resetting the canvas transform to identity first. When external code (e.g.Events.setSelectedEvents()) calledrender()directly outside of thererender()cycle, it left a dirty scroll transform on the canvas context. On the nextrerender(),clearRectoperated in the transformed coordinate space — and with a largecanvasScrollTop, the clear area shifted entirely above the visible canvas, resulting in nothing being cleared. Subsequent component renders drew on top of stale content, producing visual ghosting artifacts.The fix resets the transform to identity
(1, 0, 0, 1, 0, 0)beforeclearRect, ensuring the full physical canvas is always cleared regardless of any residual transform state.