Catch possible exception with special characters#5
Open
thorin8k wants to merge 1 commit intograyaii:masterfrom
Open
Catch possible exception with special characters#5thorin8k wants to merge 1 commit intograyaii:masterfrom
thorin8k wants to merge 1 commit intograyaii:masterfrom
Conversation
If a file has a name with special characters it will broke execution. This fix allows execution to continue and prints the wrong file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If a file has a name with special characters it will broke execution. This fix allows execution to continue and prints the wrong file.
Example
I had a SNES rom with this name:
Odekake Lester - Lelele no Le (^^; (Japan).zipThe problem in my case was the
^character, when the script was trying to parse its name it was throwing an exception.This could be fixed better but i have little experience with python.