Closed
Conversation
Member
Author
|
TODO:
|
Member
I like that idea, I often find that useful |
Member
Author
@griest024 Recent history or suggestions? I don't think we can do both. |
Member
|
Recent history |
Member
Author
|
BUG: |
acd752d to
8994ab1
Compare
Member
Author
|
Blocked by #3804 |
338522f to
f2385dc
Compare
Member
Author
|
griest024
reviewed
Oct 3, 2025
Comment on lines
14
to
24
| <daffio-docs-search-button></daffio-docs-search-button> | ||
| <daff-theme-switch-button></daff-theme-switch-button> | ||
| <daffio-docs-search-button search-mobile [icon]="true"></daffio-docs-search-button> | ||
| <daff-theme-switch-button theme-toggle-mobile></daff-theme-switch-button> | ||
| @if (isBigTablet) { | ||
| <daffio-docs-search-button></daffio-docs-search-button> | ||
| } @else { | ||
| <daffio-docs-search-button search-mobile [icon]="true"></daffio-docs-search-button> | ||
| } | ||
| @if (isBigTablet) { | ||
| <daff-theme-switch-button></daff-theme-switch-button> | ||
| } @else { | ||
| <daff-theme-switch-button theme-toggle-mobile></daff-theme-switch-button> | ||
| } |
Member
There was a problem hiding this comment.
@xelaint this fixes the double modal issue. Its not a good idea to have components in the DOM that aren't being used, its quite wasteful and will cause perf issues.
Member
Author
|
@griest024 Should I close this in favor of #4093? |
Member
sure, unless you want a cleaner place to iterate on the UI without all the other code cluttering up the commit log. #4093 should contain all of the code from this PR |
Member
Author
|
Closed in favor of #4093 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #3723
What is the new behavior?
Does this PR introduce a breaking change?
Other information