Skip to content

feat(daffio): add search feature#3800

Closed
xelaint wants to merge 10 commits intodevelopfrom
search-feature
Closed

feat(daffio): add search feature#3800
xelaint wants to merge 10 commits intodevelopfrom
search-feature

Conversation

@xelaint
Copy link
Member

@xelaint xelaint commented Jun 24, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3723

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint xelaint added package: daff.io @daffodil/daff.io status: wip This PR is WIP. It should be marked as a draft. labels Jun 24, 2025
@xelaint
Copy link
Member Author

xelaint commented Jun 24, 2025

TODO:

  • Wire up UI using algoliasearch/lite package
  • Correctly implement Angular's ActiveDescendantKeyManager and Highlightable so the keyboard events work
  • Can modal's position be adjusted on implementation? The modal is sitting to low in the center atm. It should be higher toward the top.
  • Do we want a recent history or suggestions list? @damienwebdev @griest024

@griest024
Copy link
Member

I like that idea, I often find that useful

@xelaint
Copy link
Member Author

xelaint commented Jun 25, 2025

I like that idea, I often find that useful

@griest024 Recent history or suggestions? I don't think we can do both.

@griest024
Copy link
Member

Recent history

@xelaint
Copy link
Member Author

xelaint commented Jul 17, 2025

BUG: / opens two modals at once.

@xelaint xelaint force-pushed the search-feature branch 2 times, most recently from acd752d to 8994ab1 Compare September 16, 2025 17:00
@xelaint
Copy link
Member Author

xelaint commented Sep 16, 2025

Blocked by #3804

@xelaint xelaint added status: blocked This PR or issue is blocked and cannot currently be progressed and removed status: wip This PR is WIP. It should be marked as a draft. labels Sep 16, 2025
@xelaint
Copy link
Member Author

xelaint commented Oct 1, 2025

  • Only display clear field icon when there is text in the field. Current UI is confusing since the "x" for clear can be confused with closing the modal.

Comment on lines 14 to 24
<daffio-docs-search-button></daffio-docs-search-button>
<daff-theme-switch-button></daff-theme-switch-button>
<daffio-docs-search-button search-mobile [icon]="true"></daffio-docs-search-button>
<daff-theme-switch-button theme-toggle-mobile></daff-theme-switch-button>
@if (isBigTablet) {
<daffio-docs-search-button></daffio-docs-search-button>
} @else {
<daffio-docs-search-button search-mobile [icon]="true"></daffio-docs-search-button>
}
@if (isBigTablet) {
<daff-theme-switch-button></daff-theme-switch-button>
} @else {
<daff-theme-switch-button theme-toggle-mobile></daff-theme-switch-button>
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xelaint this fixes the double modal issue. Its not a good idea to have components in the DOM that aren't being used, its quite wasteful and will cause perf issues.

@xelaint
Copy link
Member Author

xelaint commented Oct 6, 2025

@griest024 Should I close this in favor of #4093?

@griest024
Copy link
Member

@griest024 Should I close this in favor of #4093?

sure, unless you want a cleaner place to iterate on the UI without all the other code cluttering up the commit log. #4093 should contain all of the code from this PR

@xelaint
Copy link
Member Author

xelaint commented Oct 6, 2025

Closed in favor of #4093

@xelaint xelaint closed this Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: daff.io @daffodil/daff.io status: blocked This PR or issue is blocked and cannot currently be progressed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Search Modal UI

3 participants