feat(daffio): Redirect to Daffio instead of Github#4341
Open
joannalauu wants to merge 1 commit intodevelopfrom
Open
feat(daffio): Redirect to Daffio instead of Github#4341joannalauu wants to merge 1 commit intodevelopfrom
joannalauu wants to merge 1 commit intodevelopfrom
Conversation
joannalauu
force-pushed
the
docs/link-change
branch
from
5ae451b to
d9945de
Compare
xelaint
requested changes
Feb 23, 2026
| DISCORD_URL: 'https://discord.gg/BdaJVZ53sR', | ||
| REPO_URL: 'https://github.com/graycoreio/daffodil', | ||
| DEMO_URL: 'https://demo.daff.io', | ||
| DOCS_URL: '/docs/guides/getting-started', |
Member
There was a problem hiding this comment.
These should not be added as part of the branding constant since they are not really related to branding.
| <div daffHeroBody> | ||
| <div class="daffio-home-hero__actions"> | ||
| <a [href]="repoLink" target="_blank" daff-button color="primary">Get Started</a> | ||
| <a [routerLink]="docsLink" daff-button color="primary">Get Started</a> |
| <div daffCalloutBody class="daffio-sub-footer__body"> | ||
| <div class="daffio-sub-footer__actions"> | ||
| <a [href]="repoLink" target="_blank" rel="noopener noreferrer" daff-button color="light">Explore Daffodil</a> | ||
| <a [routerLink]="docsLink" daff-button color="light">Explore Daffodil</a> |
Member
There was a problem hiding this comment.
Alternately you can use DAFF_DOCS_PATH if you don't want to hardcode the path. Actually I would prefer using the constant over hardcoding.
| } | ||
| } | ||
| <a daff-button color="theme-contrast" size="sm" href="https://github.com/graycoreio/daffodil" rel="noopener noreferrer" target="_blank" quickstart-button>Get Started</a> | ||
| <a daff-button color="theme-contrast" size="sm" [routerLink]="docsLink" quickstart-button>Get Started</a> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Currently, users are redirected to Daffodil GitHub page when they click on 'Get Started' and 'Explore' on the daffio home page. Since daffio now contains more user-friendly documentation than the GitHub, it would make sense for users to be redirected to the daffio docs when they click on 'Get Started' and 'Explore'.
New behavior
Users are redirected to the daffio docs when they click on 'Get Started' and 'Explore'.
Breaking change?
Additional context