ci(commerce): Build @daffodil/commerce schematics#4342
Open
joannalauu wants to merge 5 commits intodevelopfrom
Open
ci(commerce): Build @daffodil/commerce schematics#4342joannalauu wants to merge 5 commits intodevelopfrom
@daffodil/commerce schematics#4342joannalauu wants to merge 5 commits intodevelopfrom
Conversation
joannalauu
force-pushed
the
ci/commerce-test
branch
from
5863788 to
6a190d5
Compare
joannalauu
changed the title
@daffodil/commerce schematics@daffodil/commerce schematics
joannalauu
force-pushed
the
ci/commerce-test
branch
from
1ec790b to
420b752
Compare
griest024
requested changes
Feb 23, 2026
Comment on lines
+162
to
+170
| # Driver: demo, standalone, app.config.ts | ||
| desc="driver=demo (standalone, app.config.ts)" | ||
| copy_base_app "$STANDALONE_APP_DIR" "$WORK_DIR/case-1" | ||
| raise_budget | ||
| if run_ng_add "demo" && npx ng build 2>&1; then | ||
| report_result "$case_num" "$desc" "pass" | ||
| else | ||
| report_result "$case_num" "$desc" "fail" | ||
| fi |
Member
There was a problem hiding this comment.
Each case data should be in some kind of serializable format, e.g. JSON, so that cases can easily be added and changed without modifying this file.
This will require some abstraction around what you're doing in case 7. Maybe the JSON can reference some override files that this script will know how to use. Or we have a few hardcoded starting points that the script can use.
Hopefully that makes sense. The goal is that this just becomes a for loop and the switch case is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
Fixes: #4253
New behavior
Builds the following commerce schematic configurations:
Breaking change?
Additional context