Fix 9.1 config parsing: wal_buffers configuration#14
Open
schmiddy wants to merge 2 commits intogregs1104:masterfrom
Open
Fix 9.1 config parsing: wal_buffers configuration#14schmiddy wants to merge 2 commits intogregs1104:masterfrom
schmiddy wants to merge 2 commits intogregs1104:masterfrom
Conversation
added 2 commits
October 28, 2015 19:02
to avoid blowing up with a KeyError when parsing a 9.1 config file.
|
👍 |
andreif
added a commit
to andreif/pgtune
that referenced
this pull request
Apr 7, 2016
andreif
added a commit
to andreif/pgtune
that referenced
this pull request
Apr 8, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you try to parse a 9.1 config file, you will blow up like this:
Since the
pg_settings-9.1-64file was missing a line aboutwal_buffers. Add that missing line, and solve the TODO noted about not needing to figure outwal_buffersat all. Now, the output postgresql.conf should just leavewal_buffersas it was, i.e. left at the auto-configured -1 by default.