fix: make registry project field required for gitlab/github types#97
Open
Dygerydoo wants to merge 1 commit into
Open
fix: make registry project field required for gitlab/github types#97Dygerydoo wants to merge 1 commit into
Dygerydoo wants to merge 1 commit into
Conversation
Use Zod discriminated union in RegistryEntrySchema so project is validated at schema level instead of runtime. Narrow ResolvedRegistry into typed variants (ResolvedGitLabRegistry, ResolvedGitHubRegistry, ResolvedDefaultRegistry) so constructors enforce the constraint at compile time, eliminating runtime null checks. Closes #93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RegistryEntrySchemasoprojectis validated at schema level forgitlab/githubtypes, instead of relying on runtime checksResolvedGitLabRegistry,ResolvedGitHubRegistry,ResolvedDefaultRegistry) so constructors enforce the constraint at compile timeGitLabRegistryClient,GitHubRegistryClient,GitLabRepositoryBrowser, andGitHubRepositoryBrowserTest plan
projectprojecttsc --noEmitCloses #93