Remove the conditional substat calculation of weapon Harbinger of Dawn

[sdglitched]

Remove the conditional substat calculation of weapon Harbinger of Dawn

Fixes: #498

Summary by Sourcery

Bug Fixes:

• Eliminate erroneous conditional CRIT Rate substat scaling on Harbinger of Dawn refinements that led to incorrect stat calculations.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes the weapon refinement-based conditional substat configuration for Harbinger of Dawn so that its conditional Crit Rate bonus is no longer modeled as a refinement stat array.

Class diagram for removal of HarbingerofDawn.refi_stat refinement stat configuration

classDiagram
    class WeaponStatType {
    }

    class WeaponStat {
        +WeaponStatType stat_name
        +float stat_data
    }

    class Sword {
    }

    class HarbingerofDawn {
        +list~str~ refi_desc
        +str file
        -list~WeaponStat~ refi_stat
    }

    Sword <|-- HarbingerofDawn
    WeaponStatType <.. WeaponStat
    WeaponStat <.. HarbingerofDawn

Loading

File-Level Changes

Change	Details	Files
Remove refinement-level conditional Crit Rate substat configuration for Harbinger of Dawn.	Delete the refi_stat attribute that defined refinement-specific critical rate percentage bonuses as WeaponStat entries. Leave only the description/tooltip strings and file identifier on the HarbingerofDawn weapon class, relying on other mechanisms to handle the conditional passive effect.	gi_loadouts/data/weap/swords/hbod.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#498	Stop treating Harbinger of Dawn's conditional CRIT Rate effect as an unconditional substat in loadout/stat calculations.	✅

Possibly linked issues

• [Bug] Incorrect substat calculation of weapon Harbinger of Dawn #498: PR deletes Harbinger of Dawn refinement substat so conditional crit rate is no longer always applied, fixing issue 498.

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gemini-code-assist]

Summary of Changes

Hello @sdglitched, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where the Harbinger of Dawn weapon was incorrectly applying critical rate bonuses based on its refinement level. By removing the refi_stat attribute, the weapon's critical rate calculation will now correctly reflect its intended behavior, resolving the issue reported in #498.

Highlights

• Weapon Stat Calculation: Removed the conditional refi_stat attribute from the Harbinger of Dawn weapon definition, which was incorrectly calculating critical rate based on refinement levels.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• gi_loadouts/data/weap/swords/hbod.py
  • Removed the refi_stat attribute, which previously defined conditional critical rate bonuses based on refinement levels.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request removes the static definition of conditional stats for the 'Harbinger of Dawn' weapon. The change is straightforward, consisting of deleting the refi_stat attribute from the HarbingerofDawn class. This aligns with the goal of not treating conditional buffs as static substats. The change is correct and I have no further recommendations.