Skip to content

Fix delete predictor test #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roxanne-o merged 5 commits into from
Aug 20, 2025
Merged

Fix delete predictor test #381

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57d7b4f
fix test
Aug 20, 2025
5a5dd64
Automatically reformatting code
Aug 20, 2025
6782f3e
add import
Aug 20, 2025
85f8680
Merge branch 'fix-delete-test' of https://github.com/groundlight/pyth…
Aug 20, 2025
3dc5eb6
Automatically reformatting code
Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions test/integration/test_groundlight.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,8 +877,12 @@ def test_delete_detector(gl: Groundlight):
gl.delete_detector(detector)

# Verify the detector is actually deleted
with pytest.raises(NotFoundError):
with pytest.raises(ApiException) as exc_info:
gl.get_detector(detector.id)
err = exc_info.value
assert err.status == HTTPStatus.GONE
payload = json.loads(err.body)
assert det_id in payload.get("message", "")

# Create another detector to test deletion by ID string and that an attached image query is deleted
name2 = f"Test delete detector 2 {datetime.utcnow()}"
Expand All @@ -891,8 +895,12 @@ def test_delete_detector(gl: Groundlight):
gl.delete_detector(detector2.id)

# Verify the second detector is also deleted
with pytest.raises(NotFoundError):
with pytest.raises(ApiException) as exc_info:
gl.get_detector(detector2.id)
err = exc_info.value
assert err.status == HTTPStatus.GONE
payload = json.loads(err.body)
assert det_id in payload.get("message", "")

# Verify the image query is also deleted
with pytest.raises(NotFoundException):
Expand Down