transport: add layer method to Endpoint#2710
Open
bouk wants to merge 1 commit into
Open
Conversation
Currently wrapping Endpoints in layers is possible but means you have to pass around clunky type aliases or redefine everything as a BoxService. Since we already use a BoxService inside Connection we can use BoxLayer to add a layer method to Endpoint and support constructing a Channel with layers applied to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently wrapping Endpoints in layers is possible but means you have to pass around clunky type aliases or redefine everything as a BoxService.
Solution
Since we already use a BoxService inside Connection we can use BoxLayer to add a layer method to Endpoint and support constructing a Channel with layers applied to it, without changing the public API