tonic-xds: Add A32 circuit breaking limiter#2711
Open
mingley wants to merge 3 commits into
Open
Conversation
|
|
b8bbda3 to
4609832
Compare
4609832 to
36b0376
Compare
Contributor
|
For PRs to tonic-xds, mention that in the PR title for better searchability. |
YutaoMa
reviewed
Jun 30, 2026
YutaoMa
reviewed
Jun 30, 2026
YutaoMa
reviewed
Jun 30, 2026
YutaoMa
reviewed
Jun 30, 2026
Contributor
Author
updated PR description to track #2444 and also updated title to include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
gRFC A32 circuit breaking is parsed by tonic-xds, but requests are not yet limited. This splits out the reusable enforcement primitive first so the request-lifetime behavior can be reviewed independently before production CDS/channel wiring lands.
This is part of #2444, which tracks adding xDS support to Tonic and gRPC.
Solution
client::circuit_breakingTower layer that enforcesmax_requestswith process-global counters keyed by cluster and EDS service name.Testing Done
cargo fmt --all --checkcargo check -p tonic-xds --all-featurescargo test -p tonic-xds circuit_breaking --lib