protoc-gen-rust-grpc: Always reconfigure, --fresh#2715
Merged
Conversation
002ac6d changed cmake's outdir to be different for each protobuf version. However, this was not sufficient to avoid linking errors because cmake's own files aren't rebuilt and it uses a horrible mix of old and new settings. always_reconfigure causes the rust cmake library to always run cmake to configure itself, and then we need --fresh so that cmake ignores its previous caches and actually reconfigures.
dfawley
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
002ac6d changed cmake's outdir to be different for each protobuf version. However, this was not sufficient to avoid linking errors because cmake's own files aren't rebuilt and it uses a horrible mix of old and new settings.
always_reconfigure causes the rust cmake library to always run cmake to configure itself, and then we need --fresh so that cmake ignores its previous caches and actually reconfigures.