grpc: Implement grpc-status-details-bin rich error details#2716
Open
ejona86 wants to merge 1 commit into
Open
Conversation
The existing grpc status APIs have been duplicated in grpc-protobuf, but with the addition of status payloads. The expectation is these will be removed when absl status is available. Since we now know the existing grpc status APIs will _not_ be be converted to absl status, they have been changed to use the rust-typical Result. StatusCodeError is redefined in grpc-protobuf rather than aliased from the grpc crate to allow a future 1:1 migration to absl status. This is API breaking for existing status usages; grpc-protobuf now uses a different status type and the grpc crate no longer has Status/StatusOr. This also adds a new public API grpc::StatusError::into_parts() for more efficient conversion. This could have been into_message() or message_mut(), but into_parts() seemed nicer for this struct that is unlikely to have fields added in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing grpc status APIs have been duplicated in grpc-protobuf, but with the addition of status payloads. The expectation is these will be removed when absl status is available. Since we now know the existing grpc status APIs will not be be converted to absl status, they have been changed to use the rust-typical Result.
StatusCodeError is redefined in grpc-protobuf rather than aliased from the grpc crate to allow a future 1:1 migration to absl status.
This is API breaking for existing status usages; grpc-protobuf now uses a different status type and the grpc crate no longer has Status/StatusOr.
This also adds a new public API grpc::StatusError::into_parts() for more efficient conversion. This could have been into_message() or message_mut(), but into_parts() seemed nicer for this struct that is unlikely to have fields added in the future.
CC @arjan-bal, @sauravzg