chore: removing criterion benches

[helio-frota]

Summary by Sourcery

Remove Criterion-based benchmarking from the fundamental module and workspace.

Chores:

• Delete Criterion benchmark files from the fundamental module benches.
• Remove Criterion dependencies from the fundamental module and root Cargo.toml.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes Criterion-based benchmark support from the workspace, including dependencies, bench targets, and associated source files in the fundamental module.

File-Level Changes

Change	Details	Files
Remove Criterion dependency from the fundamental module and workspace manifest.	Delete Criterion crate entry from modules/fundamental/Cargo.toml dependencies list. Delete Criterion crate entry from the root Cargo.toml dependencies list.	modules/fundamental/Cargo.toml Cargo.toml
Remove benchmark targets and source files that relied on Criterion.	Remove bench-otel bench target configuration from modules/fundamental/Cargo.toml benches section. Delete fundamental module benchmark source files for bench-otel, bench, and common helpers. Update workspace to no longer build or run these benches.	modules/fundamental/Cargo.toml modules/fundamental/benches/bench-otel.rs modules/fundamental/benches/bench.rs modules/fundamental/benches/common.rs Cargo.lock

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 1 issue, and left some high level feedback:

• The [[bench]] entries in modules/fundamental/Cargo.toml still reference benches/bench-otel.rs and other removed files; either remove these entries or update them to avoid build/bench configuration errors.
• Since all benches/*.rs files in modules/fundamental are deleted, consider removing the now-empty benches directory from the module to keep the workspace structure tidy.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The `[[bench]]` entries in `modules/fundamental/Cargo.toml` still reference `benches/bench-otel.rs` and other removed files; either remove these entries or update them to avoid build/bench configuration errors.
- Since all `benches/*.rs` files in `modules/fundamental` are deleted, consider removing the now-empty `benches` directory from the module to keep the workspace structure tidy.

## Individual Comments

### Comment 1
<location path="modules/fundamental/Cargo.toml" line_range="104-106" />
<code_context>
 name = "bench-otel"
 path = "benches/bench-otel.rs"
 harness = false
-
</code_context>
<issue_to_address>
**issue (bug_risk):** Bench target still declared for a file that has been deleted, which will cause Cargo bench failures.

This `bench-otel` entry still points to `benches/bench-otel.rs`, but that file was removed in this change. Running `cargo bench` will fail because the path no longer exists. If the benchmark is meant to be removed, also remove this `[[bench]]` section to keep the manifest consistent and avoid bench-time errors.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[ctron]

AI might have a point. I also recall that we did run those tests "somewhere" in the CI. Maybe you can double check if that's the case (or not). Thanks.

[helio-frota]

thanks, I forgot that part 👍

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.67%. Comparing base (3eba74d) to head (56dfff3).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2475      +/-   ##
==========================================
+ Coverage   71.66%   71.67%   +0.01%     
==========================================
  Files         453      453              
  Lines       27517    27517              
  Branches    27517    27517              
==========================================
+ Hits        19719    19722       +3     
+ Misses       6667     6657      -10     
- Partials     1131     1138       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.