refactor(importer): migrate log:: to tracing:: in git walker#2489
Merged
Conversation
Replace all log::debug!, log::info!, and log::trace! calls with their tracing:: equivalents in the git walker module. The tracing crate is already imported for #[instrument] and info_span! usage. Per CONVENTIONS.md: "Use tracing:: for all new code; migrate log:: when touching a file." Implements TC-5175 Assisted-by: Claude Code
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the git walker to use the tracing logging framework instead of log by mechanically replacing all existing log macros with their tracing equivalents, without altering control flow or behavior. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2489 +/- ##
==========================================
+ Coverage 71.38% 71.67% +0.28%
==========================================
Files 441 453 +12
Lines 26740 27517 +777
Branches 26740 27517 +777
==========================================
+ Hits 19089 19722 +633
- Misses 6538 6658 +120
- Partials 1113 1137 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ctron
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log::debug!,log::info!, andlog::trace!calls withtracing::equivalents inmodules/importer/src/runner/common/walker/git.rstracing::for all new code; migratelog::when touching a file"Context
This was originally bundled with the proxy fix in PR #2488 (TC-5174) but the maintainer requested it be in a dedicated commit/PR since the tracing migration is unrelated to the proxy bug fix.
Test plan
test_walkerpassestest_walker_fail_escapepassescargo xtask precommitpasses (clippy, fmt, check)Implements TC-5175
Summary by Sourcery
Enhancements: