Improve ipad targeting query param #15048
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alternative implementation that uses localStorage + query parameter instead of cookies. This avoids the need for cookie approval. Changes: - iPadDetection.ts: Use localStorage instead of cookies - sdcUrl.ts: New utility to append deviceClass query param to SDC URLs - useSDC.ts: Use appendDeviceClassParam for all SDC hooks - ReaderRevenueEpic.tsx: Use appendDeviceClassParam for direct getEpic call - ReaderRevenueBanner.tsx: Use appendDeviceClassParam for direct getBanner call - Updated tests for localStorage-based approach - Added tests for appendDeviceClassParam utility
juabara
added
Do not merge ⚠️
maintenance
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
tomrf1
reviewed
Jan 7, 2026
| * Sets the device class in localStorage if the device is detected as iPad. | ||
| * This value will be read and appended as a query parameter to SDC requests. | ||
| */ | ||
| export const setDeviceClass = (): void => { |
Contributor
Author
There was a problem hiding this comment.
thanks, the code became simpler :)
…eat-improve-ipad-targeting-query-param
tomrf1
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Replace the URL manipulation approach with custom fetch functions that properly build SDC URLs with deviceClass query parameters. This ensures the query param is correctly appended to the endpoint path rather than the base URL.
Alternative to:
#15035