Preload self-hosted video metadata when video is expected to play #15052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domlander
force-pushed
the
doml/simplify-preload-data
branch
3 times, most recently
from
263daa8 to
3c7d2bb
Compare
domlander
force-pushed
the
doml/simplify-preload-data
branch
from
3c7d2bb to
d8c83ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Preload partial data (metadata and also part of the video) when the video is expected to play.
Improves comment.
Why?
Fixes a bug with preloading metadata. The comment was correct but the code was wrong.
Simplifies the code and removes an unnecessary
useEffect.Notes
The preload attribute is sometimes ignored by browsers. I was finding this to be true when testing a HLS video on Chrome on Macbook.