Skip to content

Football match summary - empty alt text on crest #16524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewHEguardian wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −6
Open

Football match summary - empty alt text on crest #16524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions dotcom-rendering/src/components/FootballMatchHeader/FootballMatchHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,10 +379,7 @@ const Team = (props: {
isolation: 'isolate',
}}
>
<Crest
name={props.match[props.team].name}
paID={props.match[props.team].paID}
/>
<Crest paID={props.match[props.team].paID} />
{props.match.kind !== 'Fixture' ? (
<Score
score={props.match[props.team].score}
Expand Down Expand Up @@ -425,7 +422,7 @@ const TeamName = (props: {
</p>
);

const Crest = (props: { name: string; paID: string }) => (
const Crest = (props: { paID: string }) => (
<picture
css={{
...circleStyles,
Expand All @@ -436,7 +433,7 @@ const Crest = (props: { name: string; paID: string }) => (
>
<FootballCrest
teamId={props.paID}
altText={`${props.name} football crest`}
altText=""
width={40}
css={{
maxWidth: 40,
Expand Down
Loading