Remove newsletter preview - #16536
Open
bendudiak-fry wants to merge 3 commits into
Open
Conversation
bendudiak-fry
commented
Aug 10, 2026
| * | ||
| * Used by the "Browse more newsletters" link. | ||
| */ | ||
| export const tertiaryButtonTheme: Partial<ThemeButton> = { |
Author
There was a problem hiding this comment.
bendudiak-fry
commented
Aug 11, 2026
| cssOverrides={tryAgainButtonStyles} | ||
| data-ignore="global-link-styling" | ||
| > | ||
| Browse more newsletters |
Author
There was a problem hiding this comment.
The tertiary button theme was used here, and also on the newsletter preview button. Now that the preview button is removed, I've renamed the css vars in the pallete.
bendudiak-fry
force-pushed
the
remove-newsletter-preview
branch
from
August 11, 2026 08:30
122de82 to
355af2a
Compare
Removes preview button from Newsletter signup cards. Additionally removes NewsletterPreviewModal and NewsletterPreviewButton as they are no longer used
bendudiak-fry
force-pushed
the
remove-newsletter-preview
branch
from
August 11, 2026 12:46
355af2a to
2497570
Compare
bendudiak-fry
marked this pull request as ready for review
August 11, 2026 14:44
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
georgerichmond
approved these changes
Aug 11, 2026
georgerichmond
left a comment
georgerichmond
left a comment
Contributor
There was a problem hiding this comment.
Looks good nice tidyup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes the Newsletter preview button and modal.
Also removes the 'newsletter-in-article-signup-preview' A/B test as well as utility code for sending A/B test events related to the newsletter signup form.
Why?
An AB test has showed the preview modal functionality increases the dropoff rate for newsletter signups.
How has this change been tested?
As this is a removal of previous functional the existing test suites (unit, component, storybook and e2e) have been used.
Additional, the change has been deployed to CODE and reviewed visually on https://m.code.dev-theguardian.com/tv-and-radio/2026/apr/24/i-hope-it-got-disinfected-matthew-rhys-on-bravery-banter-and-wearing-a-prosthetic-penis
Screenshots