Skip to content

fix: Respect readonly settings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolaiort wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Respect readonly settings #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,11 @@ def delete_keys_by_title(self, repo, title):

return keys_deleted

def create_key(self, repo, title, key):
def create_key(self, repo, title, key, read_only):
"""Create a new GitHub deploy key."""
try:
managed_title = f"k8s-operator:{title}"
return repo.create_key(managed_title, key, read_only=True)
return repo.create_key(managed_title, key, read_only)
except github.GithubException as e:
self.logger.error(f"Error creating key: {str(e)}")
raise
Expand Down Expand Up @@ -240,13 +240,16 @@ def create_deploy_key(spec, logger, patch, **kwargs):
# Get repository
repo = github_manager.get_repository(spec['repository'])

#Extract readOnly setting
read_only = spec.get('readOnly', True)

# Handle existing keys
title = spec.get('title', 'Kubernetes-managed deploy key')
github_manager.delete_keys_by_title(repo, title)

# Generate and create new key
private_key, public_key = github_manager.generate_ssh_key()
key = github_manager.create_key(repo, title, public_key)
key = github_manager.create_key(repo, title, public_key, read_only)
logger.info(f"Created new deploy key: {key.id}")

if not github_manager.verify_key_exists(repo, key.id):
Expand Down