Add tests and documentation for tag support#173
Merged
guyfedwards merged 4 commits intoguyfedwards:masterfrom Oct 24, 2025
Merged
Add tests and documentation for tag support#173guyfedwards merged 4 commits intoguyfedwards:masterfrom
guyfedwards merged 4 commits intoguyfedwards:masterfrom
Conversation
Contributor
larsks
commented
Oct 23, 2025
larsks
commented
- Add a suite of tests to exercise the search syntax
- Update README to document the new search syntax
- Extend the 'nom add' command with tag support
- Perform some minor code cleanup in filter.go
Add a small suite of tests that exercise the new filter syntax.
Some minor changes to filter.go: - Create a FilterTerm struct to make initializing new Filterer instances a bit easier - Remove some unnecessary `var` statements - Clarify the prioritization logic around feed: vs tag: vs keyword searches
Update README.md to include documentation for the new tag syntax, including a few examples and a caveat about the implementation.
Extend the `nom add` command to support tags. With this change, `nom add`
now accepts the `--name`/`-n` and `--tag`/`-t` command line options. You
can add a feed with a feed name and tags like this:
nom add -n 'My Feed' -t news -t tech http://example.com/feed
This change preserve the prior syntax that allowed you to provide the feed
name as a second positional parameter; the following is also valid:
nom add -t news -t tech http://example.com/feed 'My Feed'
Owner
|
thanks @larsks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.