fix: "No items" screen on marking filtered item#179
Merged
guyfedwards merged 2 commits intoguyfedwards:masterfrom Jan 9, 2026
Merged
Conversation
When marking an item as read or favourite while the list is filtered, the UI incorrectly showed "No items" because UpdateList() replaced all items and cleared the filter state. This fix updates only the specific item in place using SetItem(), which preserves the active filter and remaining filtered items. Fixes guyfedwards#154 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
Owner
|
If you submit AI written code please verify that the issue is fixed. This 'fix' creates several more issues and does not fix the underlying issue as illustrated in this gif. I will leave this open for you to review/remedy but please include a gif showing the fixed state. |
Owner
|
Thanks @majiayu000 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154
Changes
SetItem()instead ofUpdateList()when marking items as read/favourite