fix: Improve error reporting by majiayu000 · Pull Request #180 · guyfedwards/nom

majiayu000 · 2025-12-30T23:49:40Z

Fixes #170

Changes

Replace silent tea.Quit calls with user-visible status messages in TUI
Replace log.Fatalf/log.Fatal with graceful handling to prevent crashes
Fix CLI to exit with code 1 on actual errors (not 0) and print error to stderr
Show error context to users instead of silently exiting

guyfedwards · 2025-12-31T11:11:28Z

Could you please add comments on the github diff for why changes were made, thanks.

majiayu000 · 2025-12-31T11:27:20Z

cmd/nom/main.go

-
-		os.Exit(0)
+		// For actual errors, print help and exit with error code
+		fmt.Fprintf(os.Stderr, "Error: %s\n\n", err)


When flag parsing fails (non-help), surface the error on stderr, show help, and exit non-zero so CLI failures are visible to users/scripts.

majiayu000 · 2025-12-31T11:27:40Z

internal/commands/commands.go

 			err := c.store.UpsertItem(&i)
 			if err != nil {
-				log.Fatalf("[commands.go] fetchAllFeeds: %e", err)
+				log.Printf("[commands.go] fetchAllFeeds: failed to upsert item: %v", err)


Avoid crashing the entire refresh on a single bad item; log the upsert failure and keep processing the rest.

majiayu000 · 2025-12-31T11:27:42Z

internal/commands/commands.go

 	mdown, err := converter.ConvertString(html)
 	if err != nil {
-		log.Fatal(err)
+		log.Printf("[commands.go] htmlToMd: failed to convert HTML to markdown: %v", err)


If HTML→Markdown conversion fails, log and fall back to raw HTML so the entry still renders instead of killing the app.

majiayu000 · 2025-12-31T11:27:44Z

internal/commands/list.go

 	fs, err := m.commands.GetAllFeeds()
 	if err != nil {
-		return tea.Quit
+		return m.list.NewStatusMessage(fmt.Sprintf("Error: %s", err))


Show a status message instead of quitting so users see why feeds failed to load.

majiayu000 · 2025-12-31T11:27:45Z

internal/commands/list.go

 			err := m.commands.store.ToggleRead(current.ID)
 			if err != nil {
-				return m, tea.Quit
+				return m, m.list.NewStatusMessage(fmt.Sprintf("Error marking read: %s", err))


Keep the TUI alive on toggle-read errors; report the problem in the status area.

majiayu000 · 2025-12-31T11:27:47Z

internal/commands/list.go

 			err := m.commands.store.ToggleFavourite(current.ID)
 			if err != nil {
-				return m, tea.Quit
+				return m, m.list.NewStatusMessage(fmt.Sprintf("Error toggling favourite: %s", err))


Same rationale as toggle-read: show an error message instead of exiting the session.

majiayu000 · 2025-12-31T11:27:48Z

internal/commands/list.go

-					// LKS: there should be an error message here
-					return m, tea.Quit
+					m.selectedArticle = nil
+					return m, m.list.NewStatusMessage(fmt.Sprintf("Error opening article: %s", err))


If rendering fails, clear selection and display an error to avoid leaving the UI stuck in the article view.

majiayu000 · 2025-12-31T11:27:49Z

internal/commands/tui.go

 		match, err := regexp.MatchString(o.Regex, url)
 		if err != nil {
-			return tea.Quit
+			log.Printf("[tui.go] OpenLink: invalid regex pattern: %v", err)


Skip invalid opener regex patterns with a log so a single bad config entry doesn't terminate the UI.

majiayu000 · 2025-12-31T11:28:16Z

internal/commands/viewport.go

 			if err != nil {
-				return m, nil
+				m.selectedArticle = nil
+				return m, m.list.NewStatusMessage("Error: failed to get article")


When the selected item can't be fetched, reset selection and show an error so the user can continue.

majiayu000 · 2025-12-31T11:28:21Z

internal/commands/viewport.go

 			if err != nil {
-				return m, tea.Quit
+				m.selectedArticle = nil
+				return m, m.list.NewStatusMessage("Error rendering article")


Render failures now surface as status messages instead of quitting, improving error visibility and resilience.

majiayu000

Added inline notes explaining the intent behind each change.

majiayu000 · 2025-12-31T14:42:33Z

cmd/nom/main.go

-
-		os.Exit(0)
+		// For actual errors, print help and exit with error code
+		fmt.Fprintf(os.Stderr, "Error: %s\n\n", err)


Reason: treat real CLI parse errors as failures (exit 1 + stderr) so scripts can detect them; help requests should still be a clean exit.

majiayu000 · 2025-12-31T14:42:33Z

internal/commands/commands.go

 			err := c.store.UpsertItem(&i)
 			if err != nil {
-				log.Fatalf("[commands.go] fetchAllFeeds: %e", err)
+				log.Printf("[commands.go] fetchAllFeeds: failed to upsert item: %v", err)


Avoid crashing the whole app on a single item upsert; log and continue so other feeds still load.

majiayu000 · 2025-12-31T14:42:33Z

internal/commands/commands.go

-		log.Fatal(err)
+		log.Printf("[commands.go] htmlToMd: failed to convert HTML to markdown: %v", err)
+		// Return the original HTML if conversion fails
+		return html


If HTML->MD conversion fails, fall back to original HTML instead of exiting so users still see content.

majiayu000 · 2025-12-31T14:42:33Z

internal/commands/list.go

 	fs, err := m.commands.GetAllFeeds()
 	if err != nil {
-		return tea.Quit
+		return m.list.NewStatusMessage(fmt.Sprintf("Error: %s", err))


Replace tea.Quit with a visible status message to avoid silent exits and keep the TUI responsive.

majiayu000 · 2025-12-31T14:42:33Z

internal/commands/tui.go

 		match, err := regexp.MatchString(o.Regex, url)
 		if err != nil {
-			return tea.Quit
+			log.Printf("[tui.go] OpenLink: invalid regex pattern: %v", err)


Invalid opener regex shouldn't kill the UI; log and skip this opener instead.

majiayu000 · 2025-12-31T14:42:33Z

internal/commands/viewport.go

 			if err != nil {
-				return m, nil
+				m.selectedArticle = nil
+				return m, m.list.NewStatusMessage("Error: failed to get article")


If the selected article can't be loaded, clear selection and surface an error instead of silently failing.

Replace silent exits and crashes with proper error messages: - main.go: Exit with code 1 on parse errors (not 0), print error to stderr - list.go: Show status messages instead of silent tea.Quit on errors - viewport.go: Return to list view with error message on failures - commands.go: Replace log.Fatal with log.Printf to avoid crashes - tui.go: Skip invalid regex patterns with log instead of crashing Closes guyfedwards#170 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>

majiayu000 commented Dec 31, 2025

View reviewed changes

guyfedwards force-pushed the fix-170-improve-error-reporting-1231-0740 branch from 3b38908 to ddea614 Compare January 23, 2026 12:07

guyfedwards merged commit 82f94d4 into guyfedwards:master Jan 23, 2026
2 checks passed

Conversation

majiayu000 commented Dec 30, 2025

Changes

Uh oh!

guyfedwards commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

majiayu000 Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

majiayu000 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

guyfedwards commented Dec 31, 2025 •

edited

Loading

majiayu000 Dec 31, 2025 •

edited

Loading