refactor: move slot types and participant protocols from DHModels to DHKit#10
Merged
refactor: move slot types and participant protocols from DHModels to DHKit#10
Conversation
…DHKit Slots (AdversarySlot, PlayerSlot, EnvironmentSlot) and the EncounterParticipant/CombatParticipant protocols represent live session state, not static catalog data. Moving them to DHKit co-locates them with EncounterSession, which is their only consumer. - Add `nonisolated` to slot structs and protocols to opt out of DHKit's `.defaultIsolation(MainActor.self)`, preserving Sendable semantics - Add `import DHModels` to moved files that reference Adversary/Condition - Move PlayerSlotTests out of DHModelsTests into new DHKitTests/SlotTests.swift alongside new AdversarySlotTests and EnvironmentSlotTests - Update CLAUDE.md placement rule: catalog/prep types → DHModels, live session types → DHKit; document the nonisolated requirement - Add DHModels-diagram.md and DHKit-diagram.md with Mermaid class diagrams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slots (AdversarySlot, PlayerSlot, EnvironmentSlot) and the EncounterParticipant/CombatParticipant protocols represent live session state, not static catalog data. Moving them to DHKit co-locates them with EncounterSession, which is their only consumer.
nonisolatedto slot structs and protocols to opt out of DHKit's.defaultIsolation(MainActor.self), preserving Sendable semanticsimport DHModelsto moved files that reference Adversary/Condition