refactor: redesign slot types, tighten protocol contracts, fix concurrency

.github/workflows/linux.yml

@@ -20,12 +20,18 @@ jobs:
       - name: Build DHModels
         run: swift build --target DHModels
 
+      - name: Build DHKit
+        run: swift build --target DHKit
+
       - name: Build validate-dhpack
         run: swift build --target validate-dhpack
 
       - name: Test DHModels
         run: swift test --filter DHModelsTests
 
+      - name: Test DHKit
+        run: swift test --filter DHKitTests
+
   swift-format:
     name: swift-format lint
     runs-on: ubuntu-latest

Package.swift

@@ -7,18 +7,33 @@ let sharedSettings: [SwiftSetting] = [
   .enableUpcomingFeature("MemberImportVisibility"),
 ]
 
-var products: [Product] = [
+let products: [Product] = [
   .library(name: "DHModels", targets: ["DHModels"]),
+  .library(name: "DHKit", targets: ["DHKit"]),
   .executable(name: "validate-dhpack", targets: ["validate-dhpack"]),
 ]
 
-var targets: [Target] = [
+let targets: [Target] = [
   // Pure Codable value types — no Apple-only imports, compiles on Linux.
   .target(
     name: "DHModels",
     swiftSettings: sharedSettings
   ),
 
+  // Observable stores + SRD bundle resources.
+  .target(
+    name: "DHKit",
+    dependencies: [
+      "DHModels",
+      .product(name: "Logging", package: "swift-log"),
+    ],
+    resources: [
+      .copy("Resources/adversaries.json"),
+      .copy("Resources/environments.json"),
+    ],
+    swiftSettings: sharedSettings + [.defaultIsolation(MainActor.self)]
+  ),
+
   // CLI tool for validating .dhpack files — depends only on DHModels.
   .executableTarget(
     name: "validate-dhpack",
@@ -36,33 +51,14 @@ var targets: [Target] = [
     resources: [.copy("Fixtures")],
     swiftSettings: sharedSettings
   ),
-]
-
-#if canImport(Darwin)
-  products.append(.library(name: "DHKit", targets: ["DHKit"]))
-  targets += [
-    // Observable stores + SRD bundle resources — Apple platforms only.
-    .target(
-      name: "DHKit",
-      dependencies: [
-        "DHModels",
-        .product(name: "Logging", package: "swift-log"),
-      ],
-      resources: [
-        .copy("Resources/adversaries.json"),
-        .copy("Resources/environments.json"),
-      ],
-      swiftSettings: sharedSettings + [.defaultIsolation(MainActor.self)]
-    ),
 
-    // Tests for DHKit — Apple platforms only.
-    .testTarget(
-      name: "DHKitTests",
-      dependencies: ["DHKit"],
-      swiftSettings: sharedSettings + [.defaultIsolation(MainActor.self)]
-    ),
-  ]
-#endif
+  // Tests for DHKit.
+  .testTarget(
+    name: "DHKitTests",
+    dependencies: ["DHKit"],
+    swiftSettings: sharedSettings + [.defaultIsolation(MainActor.self)]
+  ),
+]
 
 let package = Package(
   name: "DHModels",

Sources/DHKit/Compendium.swift

@@ -246,13 +246,13 @@ public final class Compendium {
   }
 
   /// Return all adversaries of a given role.
-  public func adversaries(ofType role: AdversaryType) -> [Adversary] {
+  public func adversaries(ofRole role: AdversaryType) -> [Adversary] {
     adversaries.filter { $0.role == role }
   }
 
   /// Full-text search across adversary names and descriptions.
   /// Uses `localizedStandardContains` for diacritic- and case-insensitive matching.
-  public func searchAdversaries(query: String) -> [Adversary] {
+  public func adversaries(matching query: String) -> [Adversary] {
     guard !query.isEmpty else { return adversaries }
     return adversaries.filter {
       $0.name.localizedStandardContains(query) || $0.flavorText.localizedStandardContains(query)
@@ -336,7 +336,7 @@ public final class Compendium {
 
   // MARK: - Private Helpers
 
-  nonisolated private static func decodeArray<T: Decodable>(
+  @concurrent nonisolated private static func decodeArray<T: Decodable>(
     _ type: T.Type, fromResource name: String, bundle: Bundle
   ) async throws -> [T] {
     guard let url = bundle.url(forResource: name, withExtension: "json") else {