#938 feat: package-owned skill resources - #970
Open
hachej wants to merge 20 commits into
Open
Conversation
…pinned-pi-characterization
…source-contract-adapter
…ter' into issue-938-complete-skill-discovery
…nto review/938-package-skill-resources # Conflicts: # packages/agent/src/server/agentHostLegacyRouteOptions.ts # packages/agent/src/server/createAgentApp.ts # packages/workspace/src/app/server/createWorkspaceAgentServer.ts
…ill-resources # Conflicts: # packages/workspace/src/app/server/createWorkspaceAgentServer.ts
This was referenced Jul 27, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates package-owned skill resources for #938 without copying package skills into downstream workspaces.
{ filesystem, path }skill locators.@hachej/boring-bi-dashboardcontribute its package root whilepackage.json#pi.skillsremains the sole skill declaration.filePathwire fallback; supported rows use one resource identity.Cross-filesystem conventional
.agents/skills/*/SKILL.mddiscovery is now kept in the dependent #942 rollup, where path-sensitive read capabilities are defined.Simplification pass
Four simplification loops reduced the review diff from +3,035 / −91 across 44 files to +2,190 / −240 across 42 files. A final independent pass found no remaining safe ≥20-line reduction and marked the implementation stable.
Key reductions:
piSkillPath,systemPromptAppend, orfilePathrepresentations;Consolidates
Supersedes the review surface of #949, #953, #956, and #958.
Proof
pnpm typecheck:changedpasses for changed packages and dependents.Review order
Review this PR first. Do not merge until review is complete. The dependent #942 rollup follows.
Refs #938.