Skip to content

Default release delta to latest pair #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yvette-carlisle merged 1 commit into from
May 13, 2026
Merged

Default release delta to latest pair #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions site/src/components/ReleaseDeltaPanel.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,7 @@ const latestComparison = delta.comparisons.find(
comparison.prerelease_tag_name === delta.prerelease.tag_name,
);
const latestComparisonTrackedCount = latestComparison?.tracked_signal_slugs.length ?? 0;
const activeComparison =
(latestComparison &&
trackedSignalsForSlugs(latestComparison.tracked_signal_slugs, trackedSignals).length > 0
? latestComparison
: delta.comparisons.find(
(comparison) =>
trackedSignalsForSlugs(comparison.tracked_signal_slugs, trackedSignals).length > 0,
)) ?? defaultComparison(delta);
const activeComparison = latestComparison ?? defaultComparison(delta);

function hasConcreteTryPath(signal: SignalCardData): boolean {
return Boolean(signal.how_to_try && signal.expected_effect);
Expand Down
10 changes: 1 addition & 9 deletions site/src/lib/release-delta.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,5 @@ export function defaultComparison(delta: ReleaseDeltaData): ReleaseComparisonDat
comparison.prerelease_tag_name === delta.prerelease.tag_name,
);

if (releaseDefault?.tracked_signal_slugs.length) {
return releaseDefault;
}

return (
delta.comparisons.find((comparison) => comparison.tracked_signal_slugs.length > 0) ??
releaseDefault ??
delta.comparisons[0]
);
return releaseDefault ?? delta.comparisons[0];
}