Skip to content

Use compact account fallback placeholders #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yvette-carlisle merged 1 commit into from
May 21, 2026
Merged

Use compact account fallback placeholders #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/decodex-app/Sources/DecodexApp/AccountPanelView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ struct AccountUsageMeterView: View {

private var remainingText: String {
guard let remainingPercent else {
return "n/a"
return "-"
}

return "\(remainingPercent)%"
Expand Down Expand Up @@ -878,9 +878,9 @@ private struct UsageResetDisplay {
static func make(resetAtUnixEpoch: Int?) -> UsageResetDisplay {
guard let seconds = resetAtUnixEpoch, seconds > 0 else {
return UsageResetDisplay(
short: "not reported",
short: "-",
date: "",
accessibility: "reset not reported"
accessibility: "reset unavailable"
)
}

Expand Down
18 changes: 9 additions & 9 deletions apps/decodex/src/orchestrator/operator_dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6139,7 +6139,7 @@ <h2 id="recent-title">Run History</h2>
}

function codexAccountPlanLabel(account) {
return account?.plan_type ? humanizeToken(account.plan_type) : "not reported";
return account?.plan_type ? humanizeToken(account.plan_type) : "-";
}

function codexAccountTokenLabel(refreshStatus) {
Expand Down Expand Up @@ -6297,9 +6297,9 @@ <h2 id="recent-title">Run History</h2>
const distance = codexAccountResetDistance(data.resetAt);
if (resetAt === "unknown" && distance.short === "unknown") {
return {
short: "not reported",
short: "-",
date: "",
aria: "reset not reported",
aria: "reset unavailable",
};
}

Expand Down Expand Up @@ -6445,7 +6445,7 @@ <h2 id="recent-title">Run History</h2>
return balance;
}
if (account.credits_has_credits === true) {
return "not reported";
return "-";
}

return null;
Expand Down Expand Up @@ -6515,18 +6515,18 @@ <h2 id="recent-title">Run History</h2>
const data = codexAccountWindowData(account, prefix);
const label = codexAccountWindowLabel(data.windowSeconds);
const remaining =
data.remainingPercent == null ? "not reported" : `${data.remainingPercent}%`;
data.remainingPercent == null ? "-" : `${data.remainingPercent}%`;
const reset = codexAccountResetDisplay(data);
const windowTone = codexAccountWindowTone(data.remainingPercent);
const toneClass = windowTone ? ` is-${windowTone}` : "";
const isUnreported = data.remainingPercent == null && reset.short === "not reported";
const isUnreported = data.remainingPercent == null && reset.short === "-";
const resetTitle = `${label} ${remaining}, ${reset.aria}`;

if (isUnreported) {
return `
<div class="account-window is-${escapeHtml(prefix)}${toneClass}" aria-label="${escapeHtml(label)} usage not reported" title="${escapeHtml(resetTitle)}">
<div class="account-window is-${escapeHtml(prefix)}${toneClass}" aria-label="${escapeHtml(label)} usage unavailable" title="${escapeHtml(resetTitle)}">
<span class="account-window-label" aria-hidden="true">${escapeHtml(label)}</span>
<strong>not reported</strong>
<strong>-</strong>
</div>
`;
}
Expand Down Expand Up @@ -6570,7 +6570,7 @@ <h2 id="recent-title">Run History</h2>
${renderCodexAccountPoolWindow(account, "secondary")}
<div class="account-row-credit${creditClass}">
<span>credits</span>
<strong>${escapeHtml(credits || "not reported")}</strong>
<strong>${escapeHtml(credits || "-")}</strong>
</div>
<div class="account-row-state">
<strong class="account-status">${escapeHtml(codexAccountStatusLabel(account))}</strong>
Expand Down
12 changes: 6 additions & 6 deletions apps/decodex/src/orchestrator/tests/operator/status/dashboard.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ fn operator_dashboard_accounts_keeps_identity_rows_compact() {
assert!(response.contains("text-align: center;"));
assert!(response.contains("function codexAccountPlanLabel(account)"));
assert!(response.contains(
"return account?.plan_type ? humanizeToken(account.plan_type) : \"not reported\";"
"return account?.plan_type ? humanizeToken(account.plan_type) : \"-\";"
));
assert!(response.contains("const plan = codexAccountPlanLabel(account);"));
assert!(response.contains("const identityClass = codexAccountShowsEmail(account) ? \" is-machine\" : \"\";"));
Expand Down Expand Up @@ -921,7 +921,7 @@ fn operator_dashboard_accounts_keeps_debug_credit_and_reset_copy_compact() {
assert!(response.contains("const credits = codexAccountCreditsSummary(account);"));
assert!(response.contains("const creditTone = codexAccountCreditsTone(account);"));
assert!(response.contains("<span>credits</span>"));
assert!(response.contains("<strong>${escapeHtml(credits || \"not reported\")}</strong>"));
assert!(response.contains("<strong>${escapeHtml(credits || \"-\")}</strong>"));

let account_credit_index = response
.find("<div class=\"account-row-credit${creditClass}\">")
Expand All @@ -937,7 +937,7 @@ fn operator_dashboard_accounts_keeps_debug_credit_and_reset_copy_compact() {
assert!(response.contains("return \"Ready\";"));
assert!(response.contains("return \"Refresh failed\";"));
assert!(response.contains("return codexAccountTokenValue(account.refresh_status);"));
assert!(response.contains("return \"not reported\";"));
assert!(response.contains("return \"-\";"));
assert!(!response.contains("depleted"));
assert!(response.contains("rate_limit_reached_type"));
assert!(response.contains("if (normalizedStatus === \"available\")"));
Expand All @@ -957,10 +957,10 @@ fn operator_dashboard_accounts_keeps_debug_credit_and_reset_copy_compact() {
assert!(response.contains("return { short, phrase: `resets in ${short}`, isPast: false };"));
assert!(response.contains("date: \"\","));
assert!(response.contains("date: resetAt,"));
assert!(response.contains("aria: \"reset not reported\","));
assert!(response.contains("aria: \"reset unavailable\","));
assert!(response.contains("reset at ${resetAt}, ${distance.phrase}"));
assert!(response.contains("data.remainingPercent == null ? \"not reported\" : `${data.remainingPercent}%`;"));
assert!(response.contains("aria-label=\"${escapeHtml(label)} usage not reported\""));
assert!(response.contains("data.remainingPercent == null ? \"-\" : `${data.remainingPercent}%`;"));
assert!(response.contains("aria-label=\"${escapeHtml(label)} usage unavailable\""));
assert!(response.contains("const resetTitle = `${label} ${remaining}, ${reset.aria}`;"));
assert!(response.contains("<span class=\"account-window-reset\">${escapeHtml(reset.short)}</span>"));
assert!(response.contains("${reset.date ? `<span class=\"account-window-date\">${escapeHtml(reset.date)}</span>` : \"\"}"));
Expand Down