Skip to content

Ignore orphan app-server responses during turn waits #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yvette-carlisle wants to merge 3 commits into from
Closed

Ignore orphan app-server responses during turn waits #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27d8335
{"schema":"decodex/commit/1","summary":"Ignore orphan app-server resp…
yvette-carlisle May 24, 2026
1635de3
{"schema":"decodex/commit/1","summary":"Ignore orphan app-server resp…
yvette-carlisle May 24, 2026
c24d8b4
{"schema":"decodex/commit/1","summary":"Accept structured app-server …
yvette-carlisle May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions apps/decodex/src/agent/app_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3062,15 +3062,22 @@ fn wait_for_turn_completion(
Some(target_turn_id),
),
)?,
JsonRpcMessage::Response(_) | JsonRpcMessage::Error(_) => {
eyre::bail!(
"Received an unexpected JSON-RPC response while waiting for turn completion."
);
},
JsonRpcMessage::Response(_) => ignore_orphan_turn_json_rpc_response(),
JsonRpcMessage::Error(_) => reject_unexpected_turn_json_rpc_error()?,
}
}
}

fn ignore_orphan_turn_json_rpc_response() {
tracing::debug!(
"Recorded and ignored orphan app-server JSON-RPC response while waiting for turn completion."
);
}

fn reject_unexpected_turn_json_rpc_error() -> crate::prelude::Result<()> {
eyre::bail!("Received an unexpected JSON-RPC error while waiting for turn completion.");
}

fn turn_wait_timeout_error(
target_thread_id: &str,
target_turn_id: &str,
Expand Down
Loading