Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Makefile.toml
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ args = [
# | task | type | cwd |
# | ---------------- | --------- | --- |
# | lint | composite | |
# | lint-fix | extend | |
# | lint-rust | command | |
# | lint-vstyle | composite | |
# | lint-vstyle-rust | command | |
Expand All @@ -152,6 +153,9 @@ dependencies = [
"lint-vstyle",
]

[tasks.lint-fix]
extend = "lint"

[tasks.lint-rust]
workspace = false
command = "cargo"
Expand Down
17 changes: 14 additions & 3 deletions apps/decodex/src/orchestrator/status.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2572,9 +2572,9 @@ where
let local_head_oid = match validate_post_review_lane_worktree(snapshot, review_handoff) {
Ok(local_head_oid) => local_head_oid,
Err(reason) => {
return Ok(PostReviewLaneStateLoad::Classification(blocked_post_review_lane(
reason,
)));
return Ok(PostReviewLaneStateLoad::Classification(
blocked_post_review_lane_from_handoff(review_handoff, reason),
));
},
};
let review_state = match review_state_inspector
Expand Down Expand Up @@ -2958,6 +2958,17 @@ fn blocked_post_review_lane(reason: &str) -> PostReviewLaneClassification {
}
}

fn blocked_post_review_lane_from_handoff(
review_handoff: &ReviewHandoffMarker,
reason: &str,
) -> PostReviewLaneClassification {
let mut classification = blocked_post_review_lane(reason);

classification.pr_url = Some(review_handoff.pr_url().to_owned());

classification
}

fn blocked_post_review_lane_status(
project: &ServiceConfig,
issue: &TrackerIssue,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,7 @@ fn build_post_review_lane_statuses_blocks_review_handoff_lineage_rewrite() {
assert_eq!(lanes.len(), 1);
assert_eq!(lanes[0].classification, "blocked");
assert_eq!(lanes[0].reason, "review_handoff_lineage_mismatch");
assert_eq!(lanes[0].pr_url.as_deref(), Some(pr_url));
}

#[test]
Expand Down
Loading