Remove manual release checksum generation#182
Merged
Conversation
…m generation","authority":"manual"}
yvette-carlisle
force-pushed
the
xy/release-v0-1-0-artifact-hash
branch
from
1429ca3 to
823b57e
Compare
yvette-carlisle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The failed v0.1.0 release passed macOS build/sign/package, then failed in the Ubuntu Release job because the Hash script assumed downloaded artifacts lived under an rsnap-/ subdirectory. The download-artifact@v8 log showed the artifact was downloaded to the workspace root layout instead, so the rsnap-/ glob matched nothing and mv failed with cannot stat. GitHub Releases already expose asset digests, so the manual checksum step is unnecessary.
Validation