Fix Liquid Glass release toolchain gating#188
Merged
Conversation
…chain gating","authority":"manual"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macos-26instead of floatingmacos-latestcargo make lint-swift-formatRoot cause
The v0.1.2 GitHub release was built on
macos-latest, which resolved tomacos-15-arm64with SDK 15.5. The current Liquid Glass path is guarded by#if compiler(>=6.2), so that release artifact compiled out the Liquid Glass code even when run on macOS 26.4.Validation
actionlint .github/workflows/language.yml .github/workflows/release.ymlcargo make lint-swift-formatcargo make lint-swiftcargo make test-macos-native-hostcargo make test-macos-native-host-stageRSNAP_NATIVE_HOST_RUST_PROFILE=final-release RSNAP_NATIVE_HOST_SWIFT_CONFIGURATION=release ./scripts/build_and_run.sh stagegit diff --checkNotes
Existing v0.1.2 release artifacts still lack Liquid Glass. A new release is required for users to receive a bundle compiled with the macOS 26 SDK.