Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/spec/capture-session.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ product level rather than binding itself to a particular window toolkit or shell
closing Settings must return Rsnap to the background menubar shell.
2. Global hotkey starts capture session (default `Alt+X`, macOS: Option+X) and can be customized
from Settings.
3. The status menu's New Capture item must use the configured capture shortcut. Shortcut display
3. The status menu's New Screenshot item must use the configured capture shortcut. Shortcut display
strings must use platform-native names such as `Option-X`, not raw event names such as
`alt+KeyX`.
4. The status menu must not expose Cancel Capture or Permissions entries. Capture cancellation is
Expand Down
4 changes: 2 additions & 2 deletions docs/spec/settings.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@ Defines:

## Status Menu

- The status menu must expose New Capture, Open Screenshots Folder, Check for Updates, Settings,
- The status menu must expose New Screenshot, Open Screenshots Folder, Check for Updates, Settings,
and Quit.
- Open Screenshots Folder must open the configured output directory, creating it first when needed.
- Check for Updates must invoke the same Sparkle-backed update check flow as the About section.
- The status menu must not expose Cancel Capture. Capture cancellation is handled in-session by
`Esc` and secondary click in both live and Frozen modes.
- The status menu must not expose Permissions as a separate menu item. Permission status and
recovery live in Settings.
- New Capture must use the same configured shortcut as the global capture hotkey.
- New Screenshot must use the same configured shortcut as the global capture hotkey.

## Settings Window

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ public final class NativeHostApplicationController: NSObject, NSApplicationDeleg

let menu = NSMenu(title: NativeHostBrand.displayName)
let captureItem = menu.addItem(
withTitle: "New Capture",
withTitle: "New Screenshot",
action: #selector(startCapture(_:)),
keyEquivalent: ""
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2002,7 +2002,7 @@ private struct CaptureSettingsPanel: View {
VStack(spacing: 8) {
SettingsHeroControlTile(
symbolName: "keyboard",
title: "New Capture Shortcut",
title: "New Screenshot Shortcut",
subtitle: "Current: \(shortcutPresentation.displayTitle)."
) {
CaptureHotKeyField(model: model)
Expand Down
2 changes: 1 addition & 1 deletion packages/rsnap-overlay/src/frozen_export.rs
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ pub fn render_frozen_overlay_export_rgba(
fn rgba_image_from_bytes(width: u32, height: u32, rgba: &[u8]) -> Result<RgbaImage> {
let expected_len = usize::try_from(width)
.ok()
.and_then(|width| usize::try_from(height).ok().map(|height| (width, height)))
.zip(usize::try_from(height).ok())
.and_then(|(width, height)| width.checked_mul(height))
.and_then(|pixels| pixels.checked_mul(4))
.ok_or_else(|| eyre::eyre!("frozen-overlay export dimensions overflow"))?;
Expand Down
2 changes: 1 addition & 1 deletion packages/rsnap-overlay/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ pub mod scroll_stitching {
fn rgba_image_from_bytes(width: u32, height: u32, rgba: &[u8]) -> Result<RgbaImage> {
let expected_len = usize::try_from(width)
.ok()
.and_then(|width| usize::try_from(height).ok().map(|height| (width, height)))
.zip(usize::try_from(height).ok())
.and_then(|(width, height)| width.checked_mul(height))
.and_then(|pixels| pixels.checked_mul(4))
.ok_or_else(|| eyre::eyre!("scroll-capture frame dimensions overflow"))?;
Expand Down
4 changes: 2 additions & 2 deletions scripts/smoke/lib/live-hud.sh
Original file line number Diff line number Diff line change
Expand Up @@ -250,13 +250,13 @@ tell application "System Events"
tell process "RsnapNativeHost"
click menu bar item 1 of menu bar 1
delay 0.06
click menu item "New Capture" of menu 1 of menu bar item 1 of menu bar 1
click menu item "New Screenshot" of menu 1 of menu bar item 1 of menu bar 1
end tell
else
tell process "Rsnap"
click menu bar item 1 of menu bar 1
delay 0.06
click menu item "New Capture" of menu 1 of menu bar item 1 of menu bar 1
click menu item "New Screenshot" of menu 1 of menu bar item 1 of menu bar 1
end tell
end if
end tell
Expand Down