Add macOS OCR action for frozen captures#48
Conversation
… macOS OCR action for frozen captures","intent":"let frozen captures recognize text locally on macOS and copy the result without adding backend settings yet","impact":"Frozen toolbar gains a Recognize Text action backed by Apple Vision OCR, app logging handles text-copy exits, and the README/spec document the new macOS-only behavior","breaking":false,"risk":"low","authority":"linear","delivery_mode":"status-only","refs":[]}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7774e545e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…Linux linting for the macOS OCR action","intent":"keep the new macOS OCR feature out of non-macOS dead-code paths so the shared Rust gate passes on Linux CI","impact":"Frozen toolbar OCR wiring now compiles cleanly across platforms by gating the toolbar variant, action handler, and assertions to macOS while preserving the macOS behavior","breaking":false,"risk":"low","authority":"linear","delivery_mode":"status-only","refs":[]}
…ir OCR queue handling and Linux lint","intent":"keep the Apple OCR action from leaking stale PNG output and ensure queued OCR requests survive mixed worker batches while the PR stays green on Linux CI","impact":"OCR now supersedes prior PNG export intent, stale PNG responses are ignored after OCR takes over, worker batches process both PNG encode and OCR requests, and the non-macOS build no longer carries an unused OCR entry point","breaking":false,"risk":"low","authority":"linear","delivery_mode":"status-only","refs":[]}
…inux-only OCR test imports","intent":"remove the last Linux-specific dead import failure from the OCR repair branch so the shared Rust checks match the verified local state","impact":"worker test imports now gate macOS-only OCR helpers behind the same platform condition as the test, avoiding a Linux clippy failure without changing runtime OCR behavior","breaking":false,"risk":"low","authority":"linear","delivery_mode":"status-only","refs":[]}
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa2ee0a3ad
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…:"repair OCR response supersession handling","intent":"keep stale OCR responses from overriding newer output intent","impact":"serializes OCR requests and ignores stale OCR completions","breaking":false,"risk":"low","authority":"linear","delivery_mode":"status-only","refs":[]}
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 609e0dd77b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…:"flush active scroll capture before OCR","intent":"keep OCR export aligned with the latest active scroll-capture state","impact":"shares the PNG export scroll-capture flush path with OCR and covers it with a regression test","breaking":false,"risk":"low","authority":"linear","delivery_mode":"status-only","refs":[]}
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…land macOS OCR action for frozen captures on main","intent":"replace the merge-queue squash-style landing for PR #48 with a policy-compliant delivery merge commit while preserving the exact tree already on main","impact":"main keeps the same OCR code but regains the two-parent delivery-style merge shape and single-line delivery contract message expected by repository history","breaking":false,"risk":"medium","authority":"linear","delivery_mode":"closeout","refs":[]}
1 participant
Summary
Recognize Textfrozen-toolbar action backed by Apple Vision OCRTextCopiedexits in the app shellTesting
cargo make fmt-rust-checkcargo make fmt-toml-checkcargo make lintcargo make test-rust