Move macOS permission recovery to startup settings#50
Merged
Conversation
…move macOS permission recovery to startup settings","intent":"restrict macOS permission recovery to startup-time settings presentation and remove runtime permission prompts or HUD permission messages","impact":"startup now opens Settings when Screen Recording, Accessibility, or Input Monitoring are missing; capture flows stop issuing just-in-time permission requests; the permissions panel only opens the matching System Settings panes; scroll-capture guard silently rejects missing-permission starts and adds regression coverage","breaking":false,"risk":"medium","authority":"linear","delivery_mode":"status-only","refs":[]}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 371e34f109
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…restore macOS permission request paths in settings","intent":"preserve startup-only permission surfacing while keeping a manual macOS request path available from the Settings permissions surface so fresh installs do not dead-end","impact":"the startup check still only opens Settings when permissions are missing, capture flows still reject missing permissions without runtime prompts, and each Settings permission button can once again trigger the matching macOS request before falling back to System Settings; logging now satisfies vstyle and the Rust checks gate is green locally","breaking":false,"risk":"medium","authority":"linear","delivery_mode":"status-only","refs":[]}
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo make fmtcargo make fmt-checkcargo make test-rustNotes