Improve selection flow hover behavior#52
Merged
aurexav merged 4 commits intoApr 3, 2026
Merged
Conversation
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5aa4734c37
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…ove selection flow hover behavior","intent":"rework live hover selection feedback so flow remains optional, light and dark themes keep usable contrast, and hovered-window targeting survives startup edge cases","impact":"the settings surface now exposes a single Selection flow toggle and thickness control, live hover keeps its scrim when flow is disabled without inheriting the frozen dashed border, and macOS live targeting filters rsnap-owned windows while retrying occluded startup presents","breaking":false,"risk":"medium","authority":"linear","delivery_mode":"status-only","refs":[{"system":"linear","id":"XY-223","role":"authority"},{"system":"github","repo":"hack-ink/rsnap","number":52,"role":"mirror"}]}
…Linux lint regression in overlay tests","intent":"keep the selection flow hover branch green on shared Linux CI by restoring platform-aware test imports and repository style conformance in overlay tests","impact":"overlay test imports once again match their macOS-only usage and the associated backend and overlay test files now satisfy clippy, rustfmt, and vstyle without changing runtime behavior","breaking":false,"risk":"low","authority":"ci","delivery_mode":"status-only","refs":[]}
…Linux-only backend test import","intent":"remove the remaining macOS-only backend test import from Linux lint paths after the selection flow hover repair branch was updated","impact":"backend tests now gate process-id access to the same macOS-only path as the test that uses it, eliminating the last Linux clippy failure without affecting runtime behavior","breaking":false,"risk":"low","authority":"ci","delivery_mode":"status-only","refs":[]}
…rantine invalid settings files on load","intent":"reject stale settings keys without letting one parse error silently reset the rest of the user config on the next save","impact":"invalid settings.toml files are moved aside to settings.invalid backups before rsnap falls back to defaults, and regression coverage now locks the non-destructive load path","breaking":false,"risk":"medium","authority":"review","delivery_mode":"status-only","refs":[]}
yvette-carlisle
force-pushed
the
yvette/xy-223-improve-light-theme-window-selection-flow-visibility-on
branch
from
e8611fb to
6960eda
Compare
aurexav
deleted the
yvette/xy-223-improve-light-theme-window-selection-flow-visibility-on
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selection flow, keep it focused on the animated ring only, and drop the legacy config aliases/keysTesting
cargo make fmt-rustcargo test -p rsnap --lib settings::testscargo test -p rsnap-overlay overlay:: --libcargo make lint-rustcargo build --release -p rsnapgit diff --check