Reduce macOS capture startup latency#55
Merged
Merged
Conversation
…educe macos capture startup latency","intent":"shrink the time from Capture activation to the first visible overlay by removing unnecessary startup work from the critical path and narrowing ScreenCaptureKit setup overhead","impact":"capture now brings up the overlay and HUD in a few dozen milliseconds on macOS, defers auxiliary windows until after first paint, avoids blocking on startup live RGB sampling, and uses the faster on-screen shareable-content path with safer self-capture filter fallback behavior","breaking":false,"risk":"medium","refs":[]}
…pair startup perf lane lint violations","intent":"bring the capture-startup latency branch back into repo lint compliance after the performance refactor pushed several startup paths past workspace style limits","impact":"extracts startup helpers and normalizes style so the macOS capture startup latency improvements still pass cargo make lint and the existing verification path","breaking":false,"risk":"low","refs":[]}
… overlay exit import","intent":"repair the Linux Rust checks failure by only importing OverlayExit on the macOS code path that uses it","impact":"keeps the startup latency branch lint-clean across platforms without changing runtime behavior","breaking":false,"risk":"low","refs":[]}
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d87156849b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…fresh live filters after deferred aux windows","intent":"repair the startup latency branch after review found that deferred loupe, toolbar, and scroll-preview creation could leave fallback ScreenCaptureKit filters blind to newly created rsnap windows","impact":"rebuilds active self-capture filters once deferred aux windows exist and adds a regression test covering the post-startup refresh path so fallback live streams do not capture auxiliary overlay windows","breaking":false,"risk":"low","refs":[]}
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification