Refine settings defaults and About panel copy#56
Merged
Conversation
yvette-carlisle
force-pushed
the
y/settings-default-sections
branch
from
31561a4 to
b4aee17
Compare
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2916516c67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…y":"refine settings defaults and about panel copy","intent":"align the Settings window defaults with startup-only permission recovery and make the About section informative without diverging from the existing settings layout","impact":"startup permission recovery now opens with Permissions expanded while normal Settings opens keep Permissions collapsed and other sections expanded; the placeholder Advanced section is removed; About now shows repo and X links plus a theme-aware follow callout; regression tests cover both section defaults and entry routing","breaking":false,"risk":"low","authority":"review","delivery_mode":"status-only","refs":[]}
…y":"repair settings-window style lint for CI","intent":"bring the settings defaults lane back into repo style compliance after the behavior and copy changes introduced vstyle-only violations on the PR head","impact":"reorders app module items to match repository layout rules, switches test imports to crate-absolute paths, and normalizes About-section short-path and spacing usage without changing runtime behavior","breaking":false,"risk":"low","authority":"ci","delivery_mode":"status-only","refs":[{"system":"github","repo":"hack-ink/rsnap","number":56,"role":"fixes-head"}]}
…y":"fix linux lint import for about callout","intent":"restore the PR head after the style-only CI repair moved RichText behind a macOS-only import even though the About section compiles on all targets","impact":"the About callout now imports RichText on every platform so Linux Rust checks can compile the settings window again without changing runtime behavior or copy","breaking":false,"risk":"low","authority":"ci","delivery_mode":"status-only","refs":[{"system":"github","repo":"hack-ink/rsnap","number":56,"role":"fixes-head"}]}
…y":"fix nightly rustfmt import order for ci","intent":"restore the PR head after the Linux import repair left the sections import block in a stable-format shape that still disagreed with nightly rustfmt in CI","impact":"reorders the About-section RichText import to match the nightly formatter used by Rust checks without changing runtime behavior, copy, or test coverage","breaking":false,"risk":"low","authority":"ci","delivery_mode":"status-only","refs":[{"system":"github","repo":"hack-ink/rsnap","number":56,"role":"fixes-head"}]}
yvette-carlisle
force-pushed
the
y/settings-default-sections
branch
from
1df76b2 to
f493575
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Permissionsexpanded only for startup missing-permission opens and leave normal Settings opens on the standard expansion profileAdvancedsection and route settings window rendering through explicit entry-based section defaultsAboutsection with repo/X links and a theme-aware follow callout without diverging from the existing settings layoutTesting