Fix frozen drag size badge placement#57
Merged
Merged
Conversation
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…:"scope frozen size badge placement to drag-region sources","intent":"repair the PR head after review pointed out that the first patch rewrote the shared size-badge fallback contract instead of only aligning dragged frozen captures with the window-frozen placement behavior","impact":"FrozenCaptureSource::DragRegion now prefers an outside placement when the toolbar reserve overlaps the default slot while live and window-frozen paths keep the existing shared fallback contract, and regression tests now lock the drag-versus-window boundary","breaking":false,"risk":"low","authority":"review","delivery_mode":"status-only","refs":[]}
yvette-carlisle
force-pushed
the
y/frozen-drag-size-badge-placement
branch
from
4e3d191 to
d822328
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification