types_from_initializers + js_from_routes + performance fixes

[skyfallwastaken]

No description provided.

[Copilot]

Pull request overview

This PR introduces generated TypeScript route helpers and serializer-derived TS types for the Svelte/Inertia frontend, along with dashboard query performance improvements (new indexes + optimized weekly aggregation).

Changes:

• Add js_from_routes + types_from_serializers tooling/config and update Svelte pages to use generated route helpers and generated TS prop types.
• Improve dashboard performance by adding partial indexes on heartbeats and replacing per-week queries with a single window-function aggregation.
• Minor dependency/version bumps and small UI/accessibility tweaks.

Reviewed changes

Copilot reviewed 45 out of 51 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
config/initializers/js_from_routes.rb	Configures generation of TS route helpers into app/javascript/api.
config/routes.rb	Adds route defaults intended for export/generation.
app/javascript/pages/**/*.svelte	Switches hardcoded paths + local prop types to generated route helpers and serializer-derived TS types.
config/initializers/types_from_serializers.rb + app/serializers/**/*	Adds serializer DSL and defines typed serializers to generate TS types.
app/models/concerns/heartbeatable.rb + app/controllers/static_pages_controller.rb	Adds weekly grouped duration query and uses it to speed up dashboard stats computation.
db/migrate/*_add_indexes_for_dashboard_performance.rb + db/schema.rb	Adds concurrent partial indexes to improve dashboard filter/stat queries.
package.json + lockfiles	Adds @js-from-routes/inertia and bumps Svelte/tsconfig versions.
.gitignore	Ignores generated route helper + generated serializer TS type output directories.
app/javascript/layouts/AppLayout.svelte	Accessibility-related markup changes and minor state logic adjustments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The nav overlay is given role="button" and keyboard handling, but it only closes on Enter. For button-like elements, Space should also activate the action; otherwise keyboard users may not be able to dismiss the overlay reliably. Consider handling both Enter and Space (or use a real <button> element).

Suggested change

	<div class="nav-overlay" class:open={navOpen} onclick={closeNav} role="button" tabindex="0" onkeydown={(e) => e.key === 'Enter' && closeNav()}></div>
	<div class="nav-overlay" class:open={navOpen} onclick={closeNav} role="button" tabindex="0" onkeydown={(e) => { if (e.key === 'Enter' || e.key === ' ' || e.key === 'Spacebar') { e.preventDefault(); closeNav(); } }}></div>

[Copilot]

This backdrop is marked role="button" with an Escape key handler, but tabindex="-1" means it won’t receive focus via keyboard navigation, so the key handler is unlikely to fire. Since you already register a document-level Escape handler, consider removing the button semantics here (e.g., use role="presentation"/no role) to avoid exposing a non-interactive ‘button’ to assistive tech.

Suggested change

	role="button"
	tabindex="-1"
	aria-label="Close logout modal"
	onkeydown={(e) => e.key === 'Escape' && closeLogout()}

[Copilot]

Adding defaults: { export: true } to these routes will change Rails URL helper output (e.g., root_path becomes /?export=true). That will break existing current_page?(root_path) checks and server-rendered links/redirects that expect / (no query string). Consider using a route-tagging approach that doesn’t alter generated URLs, or ensure callers pass export: nil / update current_page? usage accordingly.

[Copilot]

@js-from-routes/inertia pulls in @inertiajs/inertia@0.11.1, which is marked deprecated in the lockfile and brings an old axios@0.21.x dependency. Please confirm this is intentional and upgrade/swap to a maintained client library that doesn’t require the deprecated Inertia v0 package (or explicitly depend on a secure axios version if unavoidable).

[Copilot]

config.output_folder points to app/javascript/api, but that directory is currently absent and is now gitignored. Since the Svelte code imports from ../../api, a clean checkout/build will fail unless the routes file is generated as part of the build/dev startup. Please add an explicit generation step (CI/build script or bin/setup/bin/dev hook) or commit the generated output instead of ignoring it.

[Copilot]

Similarly, TypesFromSerializers writes to app/javascript/types/serializers, but the directory is absent and gitignored while the frontend imports these types. Please ensure types are generated automatically before TypeScript/Svelte compilation (or commit them) so fresh clones and deploy builds don’t fail.