refactor: nicer guard of TreeRefactFlow node type#926
Closed
Conversation
Contributor
Author
|
Context: I came across this this slightly odd code while doing something else. It turns out not to be a required change, but is a bit cleaner this way. |
Signed-off-by: Ben Price <ben@hackworthltd.com>
brprice
force-pushed
the
brprice/refactor-guard
branch
from
9ae4797 to
a720b3f
Compare
dhess
approved these changes
May 31, 2023
georgefst
approved these changes
May 31, 2023
Contributor
|
This will actually be obsoleted by #863, which should be ready for review today. |
Member
|
I will close this, in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.